Bugs Fixed

Starting with version 1.5f0, this section will give more technical info on the bugs fixed (or features added) in the various releases of FinderPop.

1.7.7, 28 Jan 99
• Allow control-clicking-and-then-immediately-letting-go to work again.

1.7.6, 03 Jan 99
• Fix grabbing by making it share code with the rest of the key-processing stuff. Unfortunately, this means that grabbing is no longer immediate.  Fix unwanted double-autopopup in 8.5.x.  “Finder Windows” now works in 8.5.1. Fix problem where I left my MBDF hanging around for longer than I should have, which caused the “TypesChange” CM plugin to crash.
Reverted to calling _SetMenuFont due to some weirdness on Asian systems.

1.7.5, 31 Oct 98
• Fix problem where blank keys in the FinderPop “Keys” panel mysteriously appeared to be pressed while the menu was being displayed.

1.7.4, 27 Oct 98
• The new MacOS 8.5 _SetMenuFont doesn’t.  At least not consistently, so I’ve reverted to the tried and trusted hackery of versions 1.7.2 and earlier for setting the menu font and size.

1.7.3, 18 Oct 98
• Keypresses while a FinderPop menu is showing now work as advertised.
But I still think the Menu Manager is doing the wrong thing by calling _OSEventAvail() followed by _GetNextEvent(), _GetNextEvent does a whole lot more than _GetOSEvent and I think it’s going to have nasty repercussions down the line…
Fix a few minor icon bugs, and tighten up error checking in the StuffIt archive walking code.

1.7.2, 29 Sep 98
• Since 1.7.1fc1 worked OK, re-released as 1.7.2.

1.7.1fc1, 29 Sep 98

• Fix nasty bug involving my patch to _CopyMask where I managed to do a _DisposeRoutineDescriptor on the original _CopyMask address, with *BAD* results if someone else had patched it.  Bad Dog, turly, Bad Dog.

1.7.0, 28 Sep 98

• Draw hierarchical menu triangle properly when font size is smaller than 12.  (Patches _CopyMask and examines the bits — yuck!)

1.6.9b2, 11 Sep 98

• Fix broken menu cache.
Try using the folder’s modification date instead of its creation date to determine if a menu needs to be rebuilt.  What a moron!
• Fix some broken 8.5 stuff — icons, menu strings, and Finder windows.
Hooo boy.

1.6.9b1, 2 Sep 98

• Fix font size bug.
Need to call LMSetSysFontSize() even if the desired size is zero.  Used to do this anyway but I foolishly inserted a test in 1.6.5.  Duhhh.

1.6.5, 16 Jun 98

• Fix stupid Prefs bug.
Doing a “GetString(-4048)” to get the name of the FinderPop Prefs file is unlikely to work when the FinderPop control panel isn’t open.

1.6.4, 09 Jun 98

• The more haste, the less speed.
Don’t create dummy front window for balloon help hackery if we’re being called from within Standard File (i.e., a contents popup.)  ResEdit apparently gets its knickers in a twist and reports all files chosen from a FinderPop contents popup as being “damaged beyond repair”.  (It’s lying, they’re fine.)

1.6.3, 08 Jun 98

• A few features more.
Try to make those little info balloons for files a bit more consistent.  Not 100% successfully, but close. For some reason balloons weren’t being displayed if the mouse was anywhere inside the current app’s front window (despite the fact that the mouse is tracking a menu.) The obvious workaround — create a dummy front window just south of Tierra Del Fuego for the duration of the _PopupMenuSelect — seems to work OK. Option-clicking a process from the process menu will hide the current app prior to switching. Command-clicking the file list in a standard file dialog box now works regardless of the setting of the “Auto CMM Popup delay” — another one of those “Doh!” bugs...

1.6.2, 15 May 98

• Bugfixes.
Set the zone to the SystemZone() before I call NewIconGetterProc(). Fixes crasher if the app zone in which we happened to be at the time this was called gets nuked (e.g., Finder quits.) 
Fix FinderPop/StandardGetFile bug: the “dummy yourData” filefilter function needs to return 0 if the item being considered is a directory. 
Only switch to Finder when the item we’ve opened is a cdev, a clipping or a clipboard.

1.6.1, 10 May 98

• Still more bugfixes.
Prefs startup/shutdown possible problem fixed. New slogan — “Click Different”, courtesy of Nathan Labhart. Add option to not colourise an item’s text if it has a label (any icon will always be label-coloured.)  Don’t ignore the “Popup Near…” settings. Install _MenuHook for _ContentsSelect so we handle “Grabbing” and the usual Get Info/Move to Trash/Show in Finder modifier key chords...

1.6.0, 29 Apr 98

• More bugfixes.
Infinite-loop alias resolution bug fixed (resolving an alias to an alias to the first alias — there are some sick people out there :-)
New implementation of icon gathering/drawing routines to avoid clashes with an app’s own menu icons. You can now delete (ctrl-cmd-opt-shift) a non-disk item in the Desktop submenu. Fixed a minor hole in Preferences saving.  Show the Finder’s “About this Computer” window when the “Largest Block…” item is selected in the “Processes” menu.

1.5.9, 13 Mar 98

• More stuff to alleviate QuickKeys/PPP Menu problems (let me know!) Allow auto-CMM-popup to be configured on an a per-application basis by adding a “Turn on/off FinderPop Control-free CM popup in” item to the Help Menu (aside: there’s some truly weird stuff going on in this area :-/ )

1.5.8, 26 Feb 98

• In an attempt to further improve stability, lock the MBDF and MDEF handles. Might alleviate QuickKeys/PPP Menu problems (let me know!) Fix Menuette bug by avoiding _DrawMenuBar while strange font/sizes are being used. Improve support for control-free clicking on text selections, etc., by patching the drag manager. Hmmm — this could be extended still further by simply patching TextEdit…

1.5.7, 13 Feb 98

• Improve stability, add command-click-a-folder-and-hold feature.
The “Save the Icon Cache” shutdownproc ShutDwnInstall flags have been changed from sdRestartOrPower | sdOnUnmount to just sdOnUnmount. Worked around crasher bug (which I'm still tracking down)  — having no “Windows” submenu meant strange things could happen if you tried to launch a FinderPop item from within an app other than the Finder.

1.5.6, 30 Jan 98

• Enhance the Standard File support so we work in all GetFile and PutFile situations (thanks to Jon Gotow for a kewl code snippet which helped here.) Add an optional “Put Away” menu item — note that this does more than the Finder’s similarly-named item in that it works on items you’ve moved from one folder to any other on the same disk, rather than only items on the desktop.

1.5.5, 8 Jan 98

• Enhance the Standard File support so we auto-open the chosen item for StandardGetFile, and go to the correct directory for StandardPutFile.
• Add support for emboldening folder names in the FinderPop submenus.
(Actually, the styles used are configurable inside the “Pref” resource stored in the “FinderPop Preferences” file — you’ll have to grab the ‘PREF’ template from the “FinderPop” control panel file.)

1.5.4exa2, 5 Jan 98

• Fix bug whereby I only called the caller’s DialogHook procedure with null events, rendering most “customised” dialogs completely useless. Duhh.

1.5.4exa1, 2 Jan 98

• Initial stab at Standard File Dialog support.

1.5.3, 8 Dec 97

• Fixes the “Empty Trash” bug
Basically we never “zeroed” the values returned from _ContextualMenuSelect if “Empty Trash” was chosen; this meant that the Finder could be told that the user selected a menu item, so people were getting all sorts of weirdness like the trash being emptied and then the “Desktop Pictures” control panel popping open…  Whoops.

1.5.2

• Fixes “Grabbing” by creating a tiny one-pixel wide window at the mouse position when starting the drag. Don’t ask.
• Adds “Empty Trash” which piggybacks onto the “Desktop” submenu code, so it’s only available if the Desktop Submenu is.

1.5.1

• We no longer display menus which are already being displayed.
• Avoid overwriting the A4 register in some very rare circumstances.
• Minor code tidy-up.

1.5 final

• Nothing changed from 1.5f11 (other than version number.)

1.5f11

• We no longer call _FindControl in our GNEFilter; this fixes a problem with Sleeper and probably quite a few other plugins which implement their own CDEFs. (Control Panels can be thought of as Finder plugins.)

1.5f10

• Allow user to switch off clicking in unused menubar area. Duhh.
• Redo algorithm for determining if the menubar area clicked in is, in fact, unused.

1.5f9

• Rewrite low-level trap-patching core routines in an attempt to get FP to work correctly in apps other than the Finder. It’s not too bad now, especially in conjunction with Apple’s Data Detector stuff for non-CMM-aware apps.
• Add Image support when dragging.
• Allow Control-clicking (or clicking and holding) in unused areas of the menubar.

1.5f8

• Hopefully fix Japanese menu font/size problems by being paranoid about SysFontFam and SysFontSize changes. 
• Fix problem where I was trying to find the filetype of every item in the Finder selection before popping up.  If you’d selected 100+ items, this could take a long time.
• Fix the “popup placement” algorithm; now, if you have either of the “Popup near Contents…” or “Popup near last selected item” checkboxes checked (in the “More Settings…” dialog), the menu should now popup in the correct position. Or close enough to it, anyway.

1.5f7

• Problems with the “Desktop” submenu where some folders were marked “unavailable.”  This was caused by a moronic programmer error (aren’t they all) where I blithely assumed that every disk had items on the desktop.
• Fix a problem where the wrong icons may have been used for certain disks in the “Finder Windows” submenu.

1.5f6

• We now check the Preferences setting before setting the italic attribute for aliases.

1.5f5

• Hopefully fixes the weird menu font and size problems that some people were seeing.  I tried about five different ways to fix it, before finally remembering the way the old comms toolbox MDEF did it.  It also helps to undo one’s changes to SysFontFam/SysFontSize before MenuHook is called. E.g., by MenuTasker.
• Implement “Desktop” submenu — will now optionally list all items on the desktop.

1.5f3

• The ObjectSupportLib “Couldn’t prepare code fragment” startup errors which some people were getting should now be fixed.  I still  don’t know what’s going on as I have never been able to reproduce the bug myself; but I moved all of the FinderPop Applescript code to 68K-land, which means we no longer link against ObjectSupportLib.
Of course, it might be that we’ll now start failing to prepare InterfaceLib
— say, turly, why are you such a pessimist?

1.5f2

• Freeware again.  Remove registration dialogs, etc.

1.5f1

• Fix cosmetic bug in Process menu when generic mini icons were being used.
• Fix generic mini icon for System/Finder.
• Changed “Volumes” to “Desktop” pending testing of Finder Dekstop code.
• Fix problem where not having a “Processes” submenu made FinderPop accidentally ignore items chosen from an embedded FinderPop menu.  Doh!  Thanks to Stephen Giles for telling me about this one.

1.5f0

• To avoid clashing with the Finder’s “click-and-a-half” spring-loaded folder mechanism for exploring a hierarchy, the minimum auto-CMM popup delay is pinned to whatever your double-click speed is; double-click speed is selectable in the Mouse  control panel.

• A crashing bug — which was exacerbated by the presence of Adobe Type Reunion — was zapped.

• Added the “FinderPop Items Folder” to the “Finder Windows” submenu — this allows you quick access to that folder when you’re not displaying the FinderPop Items in a submenu (i.e., when they’re embedded/inlined directly in the main popup menu.) Also added a “FinderPop” entry to the Processes submenu to allow quick and easy opening of the FinderPop control panel.  If anyone really objects to these features, let me know.

• The “Finder Windows” submenu now lists windows other than the normal disk-related ones; it is now possible to select a control panel, a ‘Copy Progress’ dialog or the ‘Preferences’ dialog — basically, any non-disk window in the Finder’s layer.